Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Update workflows and expected test results for Go 1.22 #15202

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

mbg
Copy link
Member

@mbg mbg commented Dec 25, 2023

This bumps the version of Go used for our query tests to 1.22 and updates the expected test output for one test accordingly.

@mbg mbg self-assigned this Dec 25, 2023
@mbg mbg force-pushed the mbg/go/1.22 branch 2 times, most recently from b2fc8d9 to 63c78fc Compare December 25, 2023 17:54
@github-actions github-actions bot added the Go label Jan 3, 2024
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to do the same for TypeParamType.ql. I've looked into it and we don't currently extract the needed information. I have put up a PR to fix this, which includes the test change: #15216 .

@mbg mbg marked this pull request as ready for review February 16, 2024 17:35
@mbg mbg requested a review from a team as a code owner February 16, 2024 17:35
@mbg mbg requested a review from owen-mc February 16, 2024 18:06
@mbg mbg changed the title Go: Support Go 1.22 Go: Update workflows and expected test results for Go 1.22 Feb 20, 2024
@mbg mbg merged commit ea67646 into main Feb 20, 2024
12 checks passed
@mbg mbg deleted the mbg/go/1.22 branch February 20, 2024 12:32
@github github deleted a comment from Jihinokokoro28177 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants