Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: add fasthttp to frameworks for coverage #15324

Merged

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jan 15, 2024

Models-as data models for the new framework fasthttp were added in this PR. This PR adds it to the list of frameworks for the models-as-data coverage report.

@owen-mc owen-mc requested a review from a team as a code owner January 15, 2024 10:20
@github-actions github-actions bot added the Go label Jan 15, 2024
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
+    `fasthttp <https://github.com/valyala/fasthttp>`_,``github.com/valyala/fasthttp*``,,5,
-    Others,``github.com/valyala/fasthttp``,,5,

@owen-mc
Copy link
Contributor Author

owen-mc commented Jan 15, 2024

(To be clear, in the second commit I have run the script to update the frameworks reports myself, though it would have been picked up automatically by a nightly job. I think next time I'll leave it for the nightly job to avoid having to find the script and guess how to run it.)

Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@owen-mc owen-mc merged commit 63a914a into github:main Jan 15, 2024
13 checks passed
@owen-mc owen-mc deleted the go/add-fasthttp-to-frameworks-for-coverage branch January 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants