Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository visibility docs for GHES are misleading with references to GitHub.com #35262

Closed
1 task done
sparrowt opened this issue Nov 12, 2024 · 8 comments · Fixed by #35282
Closed
1 task done

Repository visibility docs for GHES are misleading with references to GitHub.com #35262

sparrowt opened this issue Nov 12, 2024 · 8 comments · Fixed by #35282
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise SME reviewed An SME has reviewed this issue/PR

Comments

@sparrowt
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/[email protected]/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/setting-repository-visibility

What part(s) of the article would you like to see updated?

Both of these sections Changing from private to public and Changing from internal to public say:

The code will be visible to everyone who can visit GitHub.com.

which is not true or relevant for GitHub Enterprise Server which is self-hosted and not linked to github.com

Additional information

No response

@sparrowt sparrowt added the content This issue or pull request belongs to the Docs Content team label Nov 12, 2024
Copy link

welcome bot commented Nov 12, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 12, 2024
@sparrowt
Copy link
Author

sparrowt commented Nov 12, 2024

Ah I've found in the source it uses {% data variables.product.prodname_dotcom_the_website %} but on GHES docs that still produces the string "GitHub.com" so that needs changing or replacing I guess based on some {% ifversion ghes or ghec %} or {% ifversion ghes %}?

@Tadmanakub3

This comment was marked as spam.

@nguyenalex836
Copy link
Contributor

@sparrowt Thank you for raising this issue (and for the context regarding that source)! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@nguyenalex836 nguyenalex836 added enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Nov 12, 2024
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@sparrowt Howdy! 👋 Our SMEs confirmed we should replace {% data variables.product.prodname_dotcom_the_website %} with {% data variables.location.product_location %} 💛

Let us know if you'd like to open a PR to make this update!

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Nov 14, 2024
@Jojo-1972

This comment was marked as spam.

@nguyenalex836
Copy link
Contributor

@janbrasna I'll go ahead and merge the PR you linked above 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants