From e242a8fbebcae28b31a10d76518694473ca97c81 Mon Sep 17 00:00:00 2001 From: Jason Reed Date: Wed, 22 Apr 2020 14:09:20 -0400 Subject: [PATCH] Review comments --- extensions/ql-vscode/src/cli.ts | 3 ++- extensions/ql-vscode/src/definitions.ts | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/cli.ts b/extensions/ql-vscode/src/cli.ts index 1870aa004c1..11a6126c5fd 100644 --- a/extensions/ql-vscode/src/cli.ts +++ b/extensions/ql-vscode/src/cli.ts @@ -617,10 +617,11 @@ export class CodeQLCliServer implements Disposable { /** * Gets information about queries in a query suite. + * @param suite The suite to resolve. * @param additionalPacks A list of directories to search for qlpacks before searching in `searchPath`. * @param searchPath A list of directories to search for packs not found in `additionalPacks`. If undefined, * the default CLI search path is used. - * @returns A list of query files found + * @returns A list of query files found. */ resolveQueriesInSuite(suite: string, additionalPacks: string[], searchPath?: string[]): Promise { const args = ['--additional-packs', additionalPacks.join(path.delimiter)]; diff --git a/extensions/ql-vscode/src/definitions.ts b/extensions/ql-vscode/src/definitions.ts index 6346af5764f..26221efd9bd 100644 --- a/extensions/ql-vscode/src/definitions.ts +++ b/extensions/ql-vscode/src/definitions.ts @@ -3,7 +3,7 @@ import * as yaml from 'js-yaml'; import * as tmp from 'tmp'; import * as vscode from "vscode"; import { decodeSourceArchiveUri, zipArchiveScheme } from "./archive-filesystem-provider"; -import { EntityValue, getResultSetSchema, LineColumnLocation, UrlValue, ColumnKindCode } from "./bqrs-cli-types"; +import { ColumnKindCode, EntityValue, getResultSetSchema, LineColumnLocation, UrlValue } from "./bqrs-cli-types"; import { CodeQLCliServer } from "./cli"; import { DatabaseItem, DatabaseManager } from "./databases"; import * as helpers from './helpers'; @@ -23,7 +23,8 @@ const TEMPLATE_NAME = "selectedSourceFile"; const SELECT_QUERY_NAME = "#select"; enum KeyType { - DefinitionQuery, ReferenceQuery + DefinitionQuery = 'DefinitionQuery', + ReferenceQuery = 'ReferenceQuery', } function tagOfKeyType(keyType: KeyType): string {