Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of checks displayed inside GH action is limited to 30 #72

Closed
pere-pleo opened this issue Mar 30, 2023 · 5 comments · Fixed by #110
Closed

Number of checks displayed inside GH action is limited to 30 #72

pere-pleo opened this issue Mar 30, 2023 · 5 comments · Fixed by #110
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pere-pleo
Copy link

Describe the bug
Number of checks displayed inside GH action seems to be limited to 30. I see that the GH action failed and when I expand the menu to check the individual checks I cannot see the failing one. They are all in green because the one that failed is the 39th.

The number 30 is my guess as I counted and it was a nice round number.

To Reproduce

  • Get a GH action with more than 30 checks.
  • Get one placed in the >30th position to fail.
  • You will see a red icon on the GH action but when you expand the menu you should not see the failing one.

Expected behavior

  • All checks inside a GH action are displayed

Screenshots
Screenshot 2023-03-30 at 10 49 52

Extension Version
v0.25.3

Additional context
Add any other context about the problem here.

@pere-pleo pere-pleo added the bug Something isn't working label Mar 30, 2023
@elbrenn elbrenn added the good first issue Good for newcomers label Mar 31, 2023
@muzimuzhi
Copy link

I guess the limit 30 came from the default per_page value, see

Currently in the source code there are multiple places using per_page: 100. But as the original author of this extension commented in cschleiden/vscode-github-actions#151 (comment),

Ideally the extension should paginate until there are no more workflows.

@KetchupOnMyKetchup
Copy link
Contributor

KetchupOnMyKetchup commented Apr 11, 2023

The reason that it is set to 30 is because the default for per_page for our API call (see below) is 30.
image

It looks like in other parts of the code we set per_page: 100 for things like variables and secrets.

Having discussions now with the team about:

  • Should pull all or 100 workflows?
  • Should we pull all or 100 jobs per workflow?

@KetchupOnMyKetchup
Copy link
Contributor

Ok after discussion, the plan is:

  1. Cut off workflow runs to most recent 100
  2. Get all jobs per run and paginate using oktokit
  3. Get all workflows and paginate using octokit

Links to similar requests:

Link to PR doing pagination:

Use:
this.gitHubRepoContext.client.paginate

@KetchupOnMyKetchup
Copy link
Contributor

KetchupOnMyKetchup commented Apr 13, 2023

The PR has been completed and the fix will be available in our upcoming release v0.25.5 planned for release April 14 2023.

@KetchupOnMyKetchup
Copy link
Contributor

This is now available in the newly released version 0.25.5, thank you so much for submitting this feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
4 participants