Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of macros in the dance actions #14

Closed
sytone opened this issue Mar 20, 2023 · 8 comments
Closed

Addition of macros in the dance actions #14

sytone opened this issue Mar 20, 2023 · 8 comments

Comments

@sytone
Copy link

sytone commented Mar 20, 2023

Made a fork and allowed the SINGLE_TAP, SINGLE_HOLD, DOUBLE_TAP and DOUBLE_HOLD steps in the dance function be replaced with macros without having to have a fully manual keymap. You can modify via onyx and use this to get the latest and patch.

Also moved to use .env file and environment variables to remove hard coding.

Leaving a message here in case anyone wants to use this.

@sytone
Copy link
Author

sytone commented Mar 20, 2023

Fork: https://github.com/sytone/ergodox-macro-hax

I am using this with my moonlander.

@Phoscur
Copy link
Collaborator

Phoscur commented Mar 29, 2023

Hi @sytone,
Welcome to our little moonlander macro hax community!
I haven't tried tap dances yet, but after looking through your fork I think I really should :)

I'm switching to MacOS again for work, so I'll need to add some hax to switch keys around (Cmd<->Ctrl), I'm pretty sure that will make me work on my fork around or after easter.

Have you tried to build your firmware in Github Actions? That was my major contribution to this repo, and I am looking to keep maintaining it!
Please leave a comment in this thread #7, I would like to know what you think or if you have a different approach.

@sytone
Copy link
Author

sytone commented Apr 8, 2023

I have not had a chance to look at github, I am using WSL to build locally at the moment.

@Phoscur
Copy link
Collaborator

Phoscur commented Apr 8, 2023

I have not had a chance to look at github, I am using WSL to build locally at the moment.

Why WSL, not native Windows?

Btw:
I've noticed the cross-var package being unmaintained, why exactly do we need it?

@Phoscur
Copy link
Collaborator

Phoscur commented Apr 8, 2023

I've merged your commits in merged in Phoscur#1
please add https://github.com/Phoscur/oryx-macro-hax as upstream, rebase and add check if everything still works for you!

I'm adding something towards the original idea of #7, so we can stop commenting out each others macros - in the upcoming days.

@Phoscur
Copy link
Collaborator

Phoscur commented Apr 9, 2023

Saw your comment about refactoring the processAll function, and did that! I hope you will like my improvements and you can test them?
Phoscur#3

@Phoscur
Copy link
Collaborator

Phoscur commented Apr 12, 2023

Merged and started the migration to my fork, please confirm if it still works after my recent changes so we can close here @sytone

Needed to remove cross-env to get a clean npm audit.

@gittyeric
Copy link
Owner

Closing in favor of of Phosphor's now-canonical fork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants