Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File change by version control not detected #226

Open
PeterN opened this issue Oct 6, 2022 · 2 comments
Open

File change by version control not detected #226

PeterN opened this issue Oct 6, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed info required More information is required
Milestone

Comments

@PeterN
Copy link

PeterN commented Oct 6, 2022

When switching git branches within VS Code, scss files changed during this process are not automatically recompiled.

Possibly comes under out-of-scope as per #210, although in this case it is all within VS Code.

@glenn2223
Copy link
Owner

glenn2223 commented Oct 7, 2022

So, I assume that the compiled CSS files are excluded on branches then... damn 😂


Unless there is something I can listen out for and respond to, I'm afraid not. From my checks I could not find anything that is triggered during a branch change that I can listen out for and respond to.

If there was, I could have a new setting that users specify the commands/actions/etc. that I should listen for to trigger compilation.

Don't know if you want to have a rummage around too, just in case I missed something.

I'll keep this open for now, while I do some digging myself (with any spare time I get). As soon as I have more details, I'll respond and proceed from there.


PS, sorry for the delay

@glenn2223 glenn2223 added enhancement New feature or request question Just a question info required More information is required labels Oct 7, 2022
@glenn2223
Copy link
Owner

Seems like the extension/component has an API with an event for state changes.

https://github.com/microsoft/vscode/blob/main/extensions/git/src/api/git.d.ts#L284

I'd like this component to be quite flexible so that any extension can cause compilation if it has an event method. I'd have to sit and think about this. Maybe a custom JS file in the .vscode folder that the extension looks for and loads 🤷though this would require JS knowledge from the user

@glenn2223 glenn2223 added help wanted Extra attention is needed info required More information is required and removed info required More information is required question Just a question labels Oct 27, 2022
@glenn2223 glenn2223 added this to the v7 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed info required More information is required
Projects
None yet
Development

No branches or pull requests

2 participants