Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile issue v5 alpha 2 #43

Closed
Tealk opened this issue Mar 20, 2021 · 8 comments
Closed

compile issue v5 alpha 2 #43

Tealk opened this issue Mar 20, 2021 · 8 comments

Comments

@Tealk
Copy link

Tealk commented Mar 20, 2021

Hi,

I have found the following error while compiling

body[data-theme="dark"]

  .fa-moon::before
    content: "\f185"
body[data-theme="dark"] .fa-moon::before {
  content: "";
} 
@Tealk
Copy link
Author

Tealk commented Mar 20, 2021

Ok after compiling several times the problem has been solved.

@Tealk Tealk closed this as completed Mar 20, 2021
@glenn2223
Copy link
Owner

Hey, glad it's working for you. I'm curious how you managed to get it working after compiling the file a few times. My belief was that it's a known issue with SASS, as per #39

@Tealk
Copy link
Author

Tealk commented Mar 20, 2021

Maybe it has to do with the fact that more code is now included

The error occurred when I used the following code, I added the variables only after the compiling was already working

body[data-theme="dark"]
  
  .fa-moon::before
    content: "\f185"

as soon as i expanded the code, the error was gone

body[data-theme="dark"]
  background-color: $bg_dark

  main
    color: $text_dark
  
  .fa-moon::before
    content: "\f185"

@Tealk
Copy link
Author

Tealk commented Mar 20, 2021

because i just looked at error #39, is it possible that it is related to another extension? i also have an extension installed which gives me suggestions for fontawesome icons

@glenn2223
Copy link
Owner

is it possible that it is related to another extension?

No, I wouldn't think so.

People from the original thread report it happening in different situations (when using variables, unquoted string, etc). I suppose if the extension in question is adding text as per any of those cases then it could be at fault. However I'd say that it's still, at its root, a sass issue (as per the link @ #39)

@glenn2223
Copy link
Owner

Out of curiosity, what's the extension and how does it work?

@Tealk
Copy link
Author

Tealk commented Mar 20, 2021

@glenn2223
Copy link
Owner

I was right, there's no issue with their extension. It's simple (but effective) and drops the Unicode in as a quoted string.


To confirm: the issue here appears to be related to the known issue with SASS (as per details in #39)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants