Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSM Template: Adding fallback image #3009

Open
akanshaaa19 opened this issue Aug 7, 2024 · 1 comment · May be fixed by #3054
Open

HSM Template: Adding fallback image #3009

akanshaaa19 opened this issue Aug 7, 2024 · 1 comment · May be fixed by #3054
Assignees
Labels
bug Something isn't working on hold This is on hold Priority : Medium

Comments

@akanshaaa19
Copy link
Member

Describe the bug
On editing a hsm template with type as IMAGE, if there is no media returned we should show a fallback image.

To Reproduce
Steps to reproduce the behavior:

  1. Go to HSM templates and find a media template
  2. Click on Edit
  3. There is no image shown in the simulator
@akanshaaa19 akanshaaa19 added the bug Something isn't working label Aug 12, 2024
@madclaws madclaws moved this to To Do in DEV Priorities Aug 20, 2024
@akanshaaa19 akanshaaa19 moved this from To Do to In progress in DEV Priorities Aug 23, 2024
@akanshaaa19 akanshaaa19 linked a pull request Aug 26, 2024 that will close this issue
@akanshaaa19 akanshaaa19 linked a pull request Sep 3, 2024 that will close this issue
@akanshaaa19 akanshaaa19 linked a pull request Sep 3, 2024 that will close this issue
@kurund
Copy link
Contributor

kurund commented Sep 3, 2024

@akanshaaa19

As discussed we can't save only the attachment type without the attachment URL. Can you please check if this is something we can handle in the backend?

Showing fallback images seems wrong to me.

@kurund kurund added the on hold This is on hold label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on hold This is on hold Priority : Medium
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants