From e48dc6e653573e13c384cfc81e5b3b3713d0dce9 Mon Sep 17 00:00:00 2001 From: Boris Glimcher Date: Fri, 22 Sep 2023 20:56:00 +0300 Subject: [PATCH] fix(backend): add missing UpdateNvmeRemoteController Signed-off-by: Boris Glimcher --- pkg/backend/nvme_controller.go | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/pkg/backend/nvme_controller.go b/pkg/backend/nvme_controller.go index a94d113a..9bb2c3ba 100644 --- a/pkg/backend/nvme_controller.go +++ b/pkg/backend/nvme_controller.go @@ -16,6 +16,7 @@ import ( "github.com/google/uuid" "go.einride.tech/aip/fieldbehavior" + "go.einride.tech/aip/fieldmask" "go.einride.tech/aip/resourceid" "google.golang.org/grpc/codes" "google.golang.org/grpc/status" @@ -92,6 +93,36 @@ func (s *Server) ResetNvmeRemoteController(_ context.Context, in *pb.ResetNvmeRe return &emptypb.Empty{}, nil } +// UpdateNvmeRemoteController resets an Nvme remote controller +func (s *Server) UpdateNvmeRemoteController(_ context.Context, in *pb.UpdateNvmeRemoteControllerRequest) (*pb.NvmeRemoteController, error) { + log.Printf("UpdateNvmeRemoteController: Received from client: %v", in) + // check input correctness + if err := s.validateUpdateNvmeRemoteControllerRequest(in); err != nil { + log.Printf("error: %v", err) + return nil, err + } + // fetch object from the database + volume, ok := s.Volumes.NvmeControllers[in.NvmeRemoteController.Name] + if !ok { + if in.AllowMissing { + log.Printf("TODO: in case of AllowMissing, create a new resource, don;t return error") + } + err := status.Errorf(codes.NotFound, "unable to find key %s", in.NvmeRemoteController.Name) + log.Printf("error: %v", err) + return nil, err + } + resourceID := path.Base(volume.Name) + // update_mask = 2 + if err := fieldmask.Validate(in.UpdateMask, in.NvmeRemoteController); err != nil { + log.Printf("error: %v", err) + return nil, err + } + log.Printf("TODO: use resourceID=%v", resourceID) + response := server.ProtoClone(in.NvmeRemoteController) + // s.Volumes.NvmeControllers[in.NvmeRemoteController.Name] = response + return response, nil +} + // ListNvmeRemoteControllers lists an Nvme remote controllers func (s *Server) ListNvmeRemoteControllers(_ context.Context, in *pb.ListNvmeRemoteControllersRequest) (*pb.ListNvmeRemoteControllersResponse, error) { log.Printf("ListNvmeRemoteControllers: Received from client: %v", in)