-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce consistent use of aliases #28
Comments
I think relative paths follow a pattern of scope and aliases are used when sourcing from deeply nested modules (often 2+ levels) or outside of current scope. Naturally, this will derail over time due to lack of upkeep. I generally don’t like lint rules that enforce path behaviour as they can differ between libraries and projects. That said, if there’s a pattern that can be unified for consistency and one that can be agreed upon, it makes total sense. |
Ah, yeah, good point. Sefirot doesn't use path aliases though. Otherwise this would have broken stuff long ago as we don't compile it.
😅 Let's see what others think. I don't have any strong preference though. I'm fine with keeping whatever seems good at the time of writing. 👍 |
Yeah, general rule is that we use I think Maybe most solid option would be to always enforce I don't mind making it consistent if everybody else wants it too. |
Currently in our codebase we have all sort of import patterns like:
Should we add a rule to make this consistent? There should be plugins available, or I can write one if we can reach a consensus.
track #37 too
The text was updated successfully, but these errors were encountered: