Replies: 5 comments 2 replies
-
|
In that case, I will create rudimentary counters for accepted and rejected
requests and add the statistics to the buttonPane within RequestManager
because I dont see anywhere else to put it.
…On Tue, May 11, 2021, 1:36 AM hrj ***@***.***> wrote:
@behrens-web <https://github.com/behrens-web> Let's continue the
discussion here.
I see, Does every task have to get accepted/rejected inside RequestManager?
Yes!
If so, does it happen inside isRequestPermitted?
I think so, but not very sure of the exact details. I have been more
focussed on the layout engine recently. This part of the code was written
many years back :)
(I wanna make sure we're on the same page here.)
I think you are on the right track. Please feel free to ask questions.
Whenever I get a chance, will try to dive into more details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#273>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCX4I2KI2FRTIYFG7NTADTNDF67ANCNFSM44UPB7XA>
.
|
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Yeah sure, go ahead! This is just to let the user see a quick overview of the requests. If you want to go further, you can also indicate the percentage of rejected requests somehow. For example, as a bar-chart or pie-chart (miniature versions that will fit within the button icon). Have you used uMatrix anytime? It was a chrome/firefox plugin that showed a red/green map on the plugin icon, indicating the percentage of rejected/accepted requests. |
Beta Was this translation helpful? Give feedback.
-
|
I'm afraid I'm not familiar with it. The only plugin I have intimate
knowledge of is DESMO-J. I can display the number of accepted and rejected
requests as is or as a percentage, but that's kind of all I can do.
…On Tue, May 11, 2021, 2:02 AM hrj ***@***.***> wrote:
Yeah sure, go ahead! This is just to let the user see a quick overview of
the requests.
If you want to go further, you can also indicate the percentage of
rejected requests somehow. For example, as a bar-chart or pie-chart
(miniature versions that will fit within the button icon).
Have you used uMatrix anytime? It was a chrome/firefox plugin that showed
a red/green map on the plugin icon, indicating the percentage of
rejected/accepted requests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#273 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCX4OJECW4CZ3CVLDNQBTTNDJCFANCNFSM44UPB7XA>
.
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
When I press the ReqMgr button and it brings up a series of green and red
cells, does each cell represent a request? Does each row represent a
request? How do I know how many requests there are?
On Tue, May 11, 2021, 2:18 AM Samuel Behrens ***@***.***>
wrote:
… I'm afraid I'm not familiar with it. The only plugin I have intimate
knowledge of is DESMO-J. I can display the number of accepted and rejected
requests as is or as a percentage, but that's kind of all I can do.
On Tue, May 11, 2021, 2:02 AM hrj ***@***.***> wrote:
> Yeah sure, go ahead! This is just to let the user see a quick overview of
> the requests.
>
> If you want to go further, you can also indicate the percentage of
> rejected requests somehow. For example, as a bar-chart or pie-chart
> (miniature versions that will fit within the button icon).
>
> Have you used uMatrix anytime? It was a chrome/firefox plugin that showed
> a red/green map on the plugin icon, indicating the percentage of
> rejected/accepted requests.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#273 (reply in thread)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ASMCX4OJECW4CZ3CVLDNQBTTNDJCFANCNFSM44UPB7XA>
> .
>
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Alright, I think I got it. On the left side of the "OK" button it displays
the number of accepted requests. On the right side of the "OK" button it
displays the number of total requests.
On Wed, May 12, 2021, 9:59 AM Samuel Behrens ***@***.***>
wrote:
… When I press the ReqMgr button and it brings up a series of green and red
cells, does each cell represent a request? Does each row represent a
request? How do I know how many requests there are?
On Tue, May 11, 2021, 2:18 AM Samuel Behrens ***@***.***>
wrote:
> I'm afraid I'm not familiar with it. The only plugin I have intimate
> knowledge of is DESMO-J. I can display the number of accepted and rejected
> requests as is or as a percentage, but that's kind of all I can do.
>
> On Tue, May 11, 2021, 2:02 AM hrj ***@***.***> wrote:
>
>> Yeah sure, go ahead! This is just to let the user see a quick overview
>> of the requests.
>>
>> If you want to go further, you can also indicate the percentage of
>> rejected requests somehow. For example, as a bar-chart or pie-chart
>> (miniature versions that will fit within the button icon).
>>
>> Have you used uMatrix anytime? It was a chrome/firefox plugin that
>> showed a red/green map on the plugin icon, indicating the percentage of
>> rejected/accepted requests.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#273 (reply in thread)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ASMCX4OJECW4CZ3CVLDNQBTTNDJCFANCNFSM44UPB7XA>
>> .
>>
>
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Ok, I've submitted a pull request with my contribution to RequestManager to
gngr. Fair warning, I made the first commit before I knew how to use GPG,
but I have another commit with a GPG key attached to it because I couldn't
figure out how append worked.
On Wed, May 12, 2021, 12:32 PM Samuel Behrens ***@***.***>
wrote:
… Alright, I think I got it. On the left side of the "OK" button it displays
the number of accepted requests. On the right side of the "OK" button it
displays the number of total requests.
On Wed, May 12, 2021, 9:59 AM Samuel Behrens ***@***.***>
wrote:
> When I press the ReqMgr button and it brings up a series of green and red
> cells, does each cell represent a request? Does each row represent a
> request? How do I know how many requests there are?
>
> On Tue, May 11, 2021, 2:18 AM Samuel Behrens ***@***.***>
> wrote:
>
>> I'm afraid I'm not familiar with it. The only plugin I have intimate
>> knowledge of is DESMO-J. I can display the number of accepted and rejected
>> requests as is or as a percentage, but that's kind of all I can do.
>>
>> On Tue, May 11, 2021, 2:02 AM hrj ***@***.***> wrote:
>>
>>> Yeah sure, go ahead! This is just to let the user see a quick overview
>>> of the requests.
>>>
>>> If you want to go further, you can also indicate the percentage of
>>> rejected requests somehow. For example, as a bar-chart or pie-chart
>>> (miniature versions that will fit within the button icon).
>>>
>>> Have you used uMatrix anytime? It was a chrome/firefox plugin that
>>> showed a red/green map on the plugin icon, indicating the percentage of
>>> rejected/accepted requests.
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <#273 (reply in thread)>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/ASMCX4OJECW4CZ3CVLDNQBTTNDJCFANCNFSM44UPB7XA>
>>> .
>>>
>>
|
Beta Was this translation helpful? Give feedback.
1 reply
-
|
No worries. And I am thrilled to see your contribution. I hope you will make a fresh PR with the changes I suggested. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@behrens-web Let's continue the discussion here.
Yes!
I think so, but not very sure of the exact details. I have been more focussed on the layout engine recently. This part of the code was written many years back :)
I think you are on the right track. Please feel free to ask questions. Whenever I get a chance, will try to dive into more details.
Beta Was this translation helpful? Give feedback.
All reactions