This repository has been archived by the owner on Apr 28, 2022. It is now read-only.
[Easy] Add GPv2Contract artefact #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Dec 8, 2020
|
Seems legit! |
e00E
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Another way to test this and also useful for development is checking the docs:
cargo doc --no-deps --open
then navigate to or search for g_pv_2_settlement::Contract.
Importing the rinkeby version and specifying the address through command line arguments is fine for the demo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dependencies for GPv2 Settlement. Note, that part of the change accidentally slipped in to a hot fix I applied last week when trying to get autodeploy running (7213878)
Given the setup of hardhat (which has separate jsons for each network) we are currently specifically importing the rinkeby artefact. We also cannot automatically load the deployed address as hardhat's .json is slightly different from truffle's. Given that this is the same for the Uniswap contract it might be ok to simply define the contract addresses in code somewhere (there is also cowprotocol/ethcontract-rs#382 tracking ethers support in ethcontracts).
Test Plan
Depending on the new contract in main works (if we add contracts to the solver's Cargo.toml)