Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual upload of cover picture #994

Open
imclint21 opened this issue Oct 12, 2024 · 8 comments
Open

Manual upload of cover picture #994

imclint21 opened this issue Oct 12, 2024 · 8 comments
Labels

Comments

@imclint21
Copy link

imclint21 commented Oct 12, 2024

Hi,

For some bookmarks I would be able to upload a custom image when the automatic fetching does not works.

Regards

@mayur1377
Copy link

hey @imclint21 , I can give this a try :)

@imclint21
Copy link
Author

would be awesome!

@mayur1377
Copy link

the way the images are stored is quite inconsistent , make it difficult to work with :)
made a workaround for have a "random" placeholder if it was unable to fetch images from the provided URL ,
lemme know if I can go ahead and raise a PR :)

@imclint21
Copy link
Author

I would recommend to use https://place-hold.it/ or something neutral for default image,

Also i'm not maintainer of this project :D

@mayur1377
Copy link

@fmartingr , lemme know what to do :D

@fmartingr
Copy link
Member

fmartingr commented Oct 14, 2024

Unsure what the ask is here. It is uploading thumbnails or it is having placeholders for bookmarks without thumbnails? (I'm against placeholders)

@imclint21 As a workaround, you can put an image into the $SHIORI_DIR/thumb folder named after the ID of the bookmark. That is, if you upload an image file named 44 in that folder it should show up as thumbnail. This may change recently if we normalize data in the database but should work as of today.

@imclint21
Copy link
Author

You can edit all the metadata of any bookmark why not let the possibility to upload a custom thumb like I can edit the title?

I'm sure @mayur1377 can handle it quickly, just need to upload the new image in $SHIORI_DIR/thumb as you said.

@imclint21
Copy link
Author

imclint21 commented Oct 30, 2024

Any news on this @fmartingr @mayur1377? :D

I like Shiori but it looks bad without thumbs haha

image

@fmartingr fmartingr added component:frontend The bug is in front-end user:web labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

3 participants