-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use different error type for "internal" errors #8
Comments
I suggest to change
In a
|
But @robteix must decide if this is a breaking change or not. I personally would consider it as one as people may do error checks agains |
It is breaking but go ahead. Just do a PR to master and I'll release it as -rst Sent from my mobile |
Hello Roberto!
Have you thought of using a different error struct for internal errors (e.g.
ErrUnsupported
,ErrBadParameter
,ErrUnknownTag
)?One use case where this may be handy is to decide if I send a
http.StatusInternalServerError
or ahttp.StatusBadRequest
or maybe even do a panic because of wrong validation settings.The text was updated successfully, but these errors were encountered: