Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using caret in versioning of Go and Node in CI Job #172

Closed
duyndh opened this issue Jul 19, 2023 · 3 comments
Closed

Avoid using caret in versioning of Go and Node in CI Job #172

duyndh opened this issue Jul 19, 2023 · 3 comments
Assignees
Labels
CI/CD enhancement New feature or request
Milestone

Comments

@duyndh
Copy link
Contributor

duyndh commented Jul 19, 2023

I think we should not use caret when setting up the environment in CI to avoid compatible issues between deps.

Currently:

- name: Set up Go 1.16
  uses: actions/setup-go@v2
  with:
    go-version: ^1.16
  id: go

- name: Set up Nodejs 14
  uses: actions/setup-node@v2
  with:
    node-version: ^14.15
  id: node

CI will use Go 1.20.5 and Node 14.21.3

@nguyencatpham
Copy link
Collaborator

Go: should support the last 2 versions
@hieult1393 will choose 1 Node version supported

@nguyencatpham nguyencatpham added this to the v2 milestone Jul 23, 2023
@hieult1393
Copy link
Collaborator

@duyndh @nguyencatpham I think we could use Node version 16.20.1

@nguyencatpham
Copy link
Collaborator

already resolve by #174 and #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants