From f004c47e3c46c74aea94b8e8099d793b28c54981 Mon Sep 17 00:00:00 2001
From: Marius Goetze <marius.goetze@greenbone.net>
Date: Mon, 15 Jul 2024 10:52:13 +0200
Subject: [PATCH] fix: don't require debug level to print error details on
 failed loading of provider metadata json

---
 cmd/csaf_aggregator/processor.go  | 14 +++++++++-----
 cmd/csaf_downloader/downloader.go | 13 ++++++++-----
 2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/cmd/csaf_aggregator/processor.go b/cmd/csaf_aggregator/processor.go
index 9f10a774..5cb36283 100644
--- a/cmd/csaf_aggregator/processor.go
+++ b/cmd/csaf_aggregator/processor.go
@@ -89,17 +89,21 @@ func (w *worker) locateProviderMetadata(domain string) error {
 
 	lpmd := loader.Load(domain)
 
-	if w.processor.cfg.Verbose {
+	if !lpmd.Valid() {
 		for i := range lpmd.Messages {
-			w.log.Info(
+			w.log.Error(
 				"Loading provider-metadata.json",
 				"domain", domain,
 				"message", lpmd.Messages[i].Message)
 		}
-	}
-
-	if !lpmd.Valid() {
 		return fmt.Errorf("no valid provider-metadata.json found for '%s'", domain)
+	} else if w.processor.cfg.Verbose {
+		for i := range lpmd.Messages {
+			w.log.Debug(
+				"Loading provider-metadata.json",
+				"domain", domain,
+				"message", lpmd.Messages[i].Message)
+		}
 	}
 
 	w.metadataProvider = lpmd.Document
diff --git a/cmd/csaf_downloader/downloader.go b/cmd/csaf_downloader/downloader.go
index a0cf34e5..e370f55a 100644
--- a/cmd/csaf_downloader/downloader.go
+++ b/cmd/csaf_downloader/downloader.go
@@ -199,7 +199,14 @@ func (d *downloader) download(ctx context.Context, domain string) error {
 
 	lpmd := loader.Load(domain)
 
-	if d.cfg.verbose() {
+	if !lpmd.Valid() {
+		for i := range lpmd.Messages {
+			slog.Error("Loading provider-metadata.json",
+				"domain", domain,
+				"message", lpmd.Messages[i].Message)
+		}
+		return fmt.Errorf("no valid provider-metadata.json found for '%s': ", domain)
+	} else if d.cfg.verbose() {
 		for i := range lpmd.Messages {
 			slog.Debug("Loading provider-metadata.json",
 				"domain", domain,
@@ -207,10 +214,6 @@ func (d *downloader) download(ctx context.Context, domain string) error {
 		}
 	}
 
-	if !lpmd.Valid() {
-		return fmt.Errorf("no valid provider-metadata.json found for '%s'", domain)
-	}
-
 	base, err := url.Parse(lpmd.URL)
 	if err != nil {
 		return fmt.Errorf("invalid URL '%s': %v", lpmd.URL, err)