Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve structured logging and validation #446

Closed
bernhardreiter opened this issue Aug 28, 2023 · 1 comment
Closed

Improve structured logging and validation #446

bernhardreiter opened this issue Aug 28, 2023 · 1 comment
Assignees
@s-l-teichmann
Milestone
Release 3.0.0-beta.1

Comments

@bernhardreiter
Copy link
Member

As followup to #443, here are some minor issues and questions to be addressed:

  • Add documentation of the new logging options to csaf_downloader.md, including the defaults.
  • Add docs about validation subdirectories and behaviour if either validation or forwarding fails.
  • in cmd/csaf_downloader/config.go:
    • typo: log download should probably be loag downloads
    • comment typo: // If no special given use current working directory. special what? ;)
  • in cmd/csaf_downloader/forwarder.go:
    • comment typo: suited ti forward
  • in cmd/csaf_downloader/main.go the following slog.Info("No domains given.") should be at least level Warning, if not Error.
@bernhardreiter bernhardreiter added this to the Release 3.0.0-beta.1 milestone Aug 28, 2023
@s-l-teichmann s-l-teichmann mentioned this issue Aug 28, 2023
Merged
@s-l-teichmann
Copy link
Contributor

Solved by #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-l-teichmann s-l-teichmann

Labels
None yet
Projects
None yet
Milestone
Release 3.0.0-beta.1
Development

No branches or pull requests
2 participants
@s-l-teichmann @bernhardreiter