Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between schema in repo and schema on first.org for CVSS 3.0 #453

Closed
cintek opened this issue Sep 4, 2023 · 3 comments
Closed
Assignees

Comments

@cintek
Copy link
Contributor

cintek commented Sep 4, 2023

Something seems wrong with the schema for CVSS 3.0.

In https://github.com/csaf-poc/csaf_distribution/blob/main/csaf/schema/cvss-v3.0.json the pattern for vectorString is: "^CVSS:3[.]0/((AV:[NALP]|AC:[LH]|PR:[UNLH]|UI:[NR]|S:[UC]|[CIA]:[NLH]|E:[XUPFH]|RL:[XOTWU]|RC:[XURC]|[CIA]R:[XLMH]|MAV:[XNALP]|MAC:[XLH]|MPR:[XUNLH]|MUI:[XNR]|MS:[XUC]|M[CIA]:[XNLH])/)*(AV:[NALP]|AC:[LH]|PR:[UNLH]|UI:[NR]|S:[UC]|[CIA]:[NLH]|E:[XUPFH]|RL:[XOTWU]|RC:[XURC]|[CIA]R:[XLMH]|MAV:[XNALP]|MAC:[XLH]|MPR:[XUNLH]|MUI:[XNR]|MS:[XUC]|M[CIA]:[XNLH])$"

But at https://www.first.org/cvss/cvss-v3.0.json the pattern for vectorString is: "^CVSS:3[.]0/((AV:[NALP]|AC:[LH]|PR:[NLH]|UI:[NR]|S:[UC]|[CIA]:[NLH]|E:[XUPFH]|RL:[XOTWU]|RC:[XURC]|[CIA]R:[XLMH]|MAV:[XNALP]|MAC:[XLH]|MPR:[XNLH]|MUI:[XNR]|MS:[XUC]|M[CIA]:[XNLH])/)*(AV:[NALP]|AC:[LH]|PR:[NLH]|UI:[NR]|S:[UC]|[CIA]:[NLH]|E:[XUPFH]|RL:[XOTWU]|RC:[XURC]|[CIA]R:[XLMH]|MAV:[XNALP]|MAC:[XLH]|MPR:[XNLH]|MUI:[XNR]|MS:[XUC]|M[CIA]:[XNLH])$"

They are not identical.

I would expect that they are the same because they have the same ID.

@bernhardreiter
Copy link
Member

Yes, can you look at the commit that added our version? The schema may have evolved since then and the version number in the file name v3.0 refers to the CVSS standard, not the revision of the JSON schema, I think...

@cintek
Copy link
Contributor Author

cintek commented Sep 7, 2023

Indeed, the schema did change a few times in the past. The wayback machine shows that the schema used in the repo did exist in the past.

Since I'm working on an advisory struct containing CVSS structs I can add the updated schema before I create a PR.

@JanHoefelmeyer
Copy link
Contributor

Solved via #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants