Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to multi-zones #17

Open
themrwookiee opened this issue Feb 15, 2024 · 0 comments
Open

Adding support to multi-zones #17

themrwookiee opened this issue Feb 15, 2024 · 0 comments

Comments

@themrwookiee
Copy link

Hi @mww012 , acd added support in his recent changes and I was wondering if you are planning to add support? To be honest I tried to update the current code and the way zones are added is beyond my comprehension of golang and python haha.

I did identify where the major changes are.

Here's your api :

return &TStatZoneConfig{
		TempUnit:        infinity.tempUnitStr(),
		CurrentTemp:     params.Z1CurrentTemp,
		CurrentHumidity: params.Z1CurrentHumidity,
		OutdoorTemp:     params.OutdoorAirTemp,
		Mode:            rawModeToString(params.Mode & 0xf),
		Stage:           params.Mode >> 5,
		FanMode:         rawFanModeToString(cfg.Z1FanMode),
		Hold:            hold,
		HoldDuration:    cfg.Z1HoldDuration,
		HeatSetpoint:    cfg.Z1HeatSetpoint,
		CoolSetpoint:    cfg.Z1CoolSetpoint,
		TargetHum:       cfg.Z1TargetHumidity,
		RawMode:         params.Mode,
	}, true

Here's his :

return &TStatZoneConfig{
		CurrentTemp:     params.GetZonalField(zone, "CurrentTemp").(uint8),
		CurrentHumidity: params.GetZonalField(zone, "CurrentHumidity").(uint8),
		OutdoorTemp:     params.OutdoorAirTemp,
		Mode:            RawModeToString(params.Mode & 0xf),
		Stage:           params.Mode >> 5,
		FanMode:         RawFanModeToString(cfg.GetZonalField(zone, "FanMode").(uint8)),
		Hold:            hold,
		HeatSetpoint:    cfg.GetZonalField(zone, "HeatSetpoint").(uint8),
		CoolSetpoint:    cfg.GetZonalField(zone, "CoolSetpoint").(uint8),
		RawMode:         params.Mode,
	}, true

If I can help, please let me know !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant