Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipsos Access not displaying in All Projects view #239

Open
dreeves4321 opened this issue Oct 16, 2024 · 14 comments
Open

Ipsos Access not displaying in All Projects view #239

dreeves4321 opened this issue Oct 16, 2024 · 14 comments

Comments

@dreeves4321
Copy link
Member

Go to All Projects view. The project Ipsos - Access is not findable.
Go to All People > Daniel Reeves. You can find Ipsos - Access and view the project, so it is valid.
Not sure if there are other missing projects.

@dreeves4321 dreeves4321 changed the title Ipsos Access now displaying in All Projects view Ipsos Access not displaying in All Projects view Oct 16, 2024
@fermion
Copy link
Collaborator

fermion commented Oct 16, 2024

@jsonin you may need to invite myself or @HankC138 do the GoInvo account in order for us to look into this.

@jsonin
Copy link
Contributor

jsonin commented Oct 16, 2024

@fermion Yup, Corbin is part of the GoInvo account. !

@fermion
Copy link
Collaborator

fermion commented Oct 16, 2024

@jsonin okay, I don't think I am so I can't really look into this. @HankC138 LMK if it might be a data issue 🙏🏻

@HankC138
Copy link
Collaborator

@jsonin okay, I don't think I am so I can't really look into this. @HankC138 LMK if it might be a data issue 🙏🏻

no problem I'll look at it now

@HankC138
Copy link
Collaborator

@dreeves4321 when you are on the allprojects screen do you have "show archived projects" view toggled? The project appears to be archived so it'll only show when you have that view enabled.

image
image

@dreeves4321
Copy link
Member Author

dreeves4321 commented Oct 16, 2024 via email

@fermion
Copy link
Collaborator

fermion commented Oct 16, 2024

We need to maybe review how to handle project archiving. That definitely
happened by somebody's mistake

Any suggestions? I'd propose we make this an admin+ feature, so only account admins and owners can do it.

there's no record of the project being archived when seen in a person's plan

IMO this is a bug. We shouldn't show archived projects anywhere unless "show archived" is enabled.

Which leads to the larger issue of archiving people and assignments.

Can you elaborate on what the issue is?

@jsonin
Copy link
Contributor

jsonin commented Oct 16, 2024

Relevant side quest: #238 (comment)

@HankC138
Copy link
Collaborator

IMO this is a bug. We shouldn't show archived projects anywhere unless "show archived" is enabled.

in terms of viewing someones personal staffplan you're viewing their assignments, which ALSO have an archived status and that is what we are basing what is shown to the user. An archived project doesn't necessarily mean the assignments for that project are archived, though maybe they should be? Should there be a batch mutation for assignments that when a project is archived the assignments are all thusly archived as well? Would the same be true whenever we figure out about unarchiving?

@fermion
Copy link
Collaborator

fermion commented Oct 16, 2024

@jsonin would you expect that when a project is archived that all assignments are also archived? Maybe that's the missing feature.

@jsonin
Copy link
Contributor

jsonin commented Oct 16, 2024

When the whole project is archived, that sounds right @fermion.
When a single person's staffplan for a project is deleted, that's vaporized.
When a single person's staffplan for a project is archived... its only archived on the individual's staffplan, so they dont see it? But it's still a part of the greater project?

I dont want this to get tooooo fussy.

Delete = straight forward
Archive = mmmm.

Maybe it's a Show/Hide philosophy (vs Archive)... since we do want to have durable projects and assignments and want to show people on rollups, even if the people aren't charging/planning but have been in the past.

@dreeves4321
Copy link
Member Author

dreeves4321 commented Oct 16, 2024 via email

@jen-p
Copy link
Member

jen-p commented Oct 16, 2024

Additionally, I (as a user) shouldn't be able to hide assignments from another user on their own Staffplan page.

edit: added new ticket for this feature.

@fermion
Copy link
Collaborator

fermion commented Oct 16, 2024

@jen-p @dreeves4321 @jsonin these are all great features / suggestions! Would you mind making issues to capture all of these so they aren't lost in this thread? Ideally one issue per feature / suggestion, leaning more granular 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

5 participants