Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace config of CLI under proctor #51

Open
olttwa opened this issue Nov 14, 2018 · 0 comments
Open

Namespace config of CLI under proctor #51

olttwa opened this issue Nov 14, 2018 · 0 comments

Comments

@olttwa
Copy link
Member

olttwa commented Nov 14, 2018

As an admin,
I don't want existing config of users to be accidentally used when running proctor. Currently, CLI has config with keys EMAIL_ID and ACCESS_TOKEN. Since these are common keys, user might have them set as ENV vars.

When proctor runs, it might pick preset config without user's knowledge.

In order to avoid such behavior, we can namespace config under PROCTOR_. Example: PROCTOR_EMAIL_ID and PROCTOR_ACCESS_TOKEN

@olttwa olttwa changed the title Namespace config of CLI under PROCTOR_ Namespace config of CLI under proctor Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant