Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Docker builds not using cache #134

Open
christopherperry opened this issue Apr 5, 2018 · 7 comments
Open

Docker builds not using cache #134

christopherperry opened this issue Apr 5, 2018 · 7 comments
Assignees

Comments

@christopherperry
Copy link
Contributor

Every build through docker does a lot of things that could probably be cached. I couldn't get a local build to work, so iterating via the docker build is quite a pain.

@artem-zinnatullin
Copy link
Collaborator

You mean ci/build.sh right?

Just want to make sure you're not talking about dockerized integration of Composer in your project :)

@artem-zinnatullin
Copy link
Collaborator

I see a PR from you, so I can assume you mean ci/build.sh

@artem-zinnatullin
Copy link
Collaborator

Yeah, build is not as fast as I'd like it to be,

Quick suggestion tho: you don't need to run it through Docker every time, you can build it once so we have generated HTML report files and then just iterate over composer module with Gradle/IDE: ./gradlew build

@christopherperry
Copy link
Contributor Author

@artem-zinnatullin Sorry for the late reply, yes I'm talking about ci/build.sh

@christopherperry
Copy link
Contributor Author

Quick suggestion tho: you don't need to run it through Docker every time, you can build it once so we have generated HTML report files and then just iterate over composer module with Gradle/IDE: ./gradlew build

Awesome. Ok. Maybe that should be added to the README? I tried to build via Gradle and had a test failure which I found confusing so I reached for the docker build.

@artem-zinnatullin
Copy link
Collaborator

Let me try to optimize Docker build first :)

@artem-zinnatullin
Copy link
Collaborator

It's a bit tricky to cache properly, I'm gonna do few incremental improvements first

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants