x/build/env/linux-arm64-bookworm: restore a working bzr installation #71563
Assignees
Labels
arch-arm64
Builders
x/build issues (builders, bots, dashboards)
NeedsFix
The path to resolution is known, but the work has not been done.
OS-Linux
Milestone
Comments
dmitshur
added
Builders
|
Change https://go.dev/cl/646715 mentions this issue: |
|
Related Code Changes (Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
gopherbot
pushed a commit
that referenced
this issue
Feb 5, 2025
It appears to be quite easy to end up with a broken 'bzr' installation. For example, if bzr was installed via a system-wide package manager and intends to work with a system-wide Python installation, it may break if another 'python3' binary is added to PATH. If something as simple as 'bzr help' fails to exit with zero code, consider it broken and skip tests that require a working bzr binary just like if the 'bzr' binary isn't present in PATH at all. This makes these tests more robust and capable of producing useful signal in more environments. Separately from this, we'll want to restore a working bzr installation on the linux-arm64 builders, but at least there's still one on linux-amd64 builders. For #71563. Fixes #71504. Change-Id: Ia147196f12b90a0731ebbfab63b5de308212ed65 Cq-Include-Trybots: luci.golang.try:gotip-linux-arm64-longtest,gotip-linux-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/646715 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
dmitshur
added
NeedsFix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The linux-arm64-bookworm image installs bzr via apt get, and that installation intends to work with the system python in /usr/bin. However, golangbuild ends up having a different version of the
python3binary added in front of its PATH. That seems fragile, and a recent update of thatpython3binary did in fact break things (see #71504).It's probably better for cmd/go tests to detect broken bzr binaries and not try to run (since they'll invariably fail without actually testing the intended code paths and providing useful signal). This is a builder-specific tracking issue to restore a working
bzrinstallation on linux/arm64 builders so that the tests can run and provide useful signal.The text was updated successfully, but these errors were encountered: