Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'knmi' sets "version" directly to update a config entry #122

Closed
1 task done
Mariusthvdb opened this issue Feb 25, 2024 · 3 comments · Fixed by #134
Closed
1 task done

'knmi' sets "version" directly to update a config entry #122

Mariusthvdb opened this issue Feb 25, 2024 · 3 comments · Fixed by #134
Labels
bug Something isn't working enhancement New feature or request

Comments

@Mariusthvdb
Copy link

Did you read the instructions?

The problem

thanks for the update,
please see new issue

Integration version

2.0.0

Home Assistant version

2024.3.0.dev20240225

Python version

3.12.2

Home Assistant log

Logger: homeassistant.helpers.frame
Bron: helpers/frame.py:133
First occurred: 23:00:08 (1 gebeurtenissen)
Laatst gelogd: 23:00:08

Detected that custom integration 'knmi' sets "version" directly to update a config entry. This is deprecated and will stop working in Home Assistant 2024.9, it should be updated to use async_update_entry instead at custom_components/knmi/__init__.py, line 102: config_entry.version = 2, please create a bug report at https://github.com/golles/ha-knmi/issues

Diagnostics

No response

Additional information

No response

@Mariusthvdb Mariusthvdb added the bug Something isn't working label Feb 25, 2024
@golles
Copy link
Owner

golles commented Feb 25, 2024

I'm aware of this, but have to do this still as 2024.2 doesn't allow me to set the version with hass.config_entries.async_update_entry(config_entry, version=2), I've already have this documented in code: https://github.com/golles/ha-knmi/blob/main/custom_components/knmi/__init__.py#L99-L102

@Mariusthvdb
Copy link
Author

nice, my pardon, I didnt check the code.....

@golles
Copy link
Owner

golles commented Feb 25, 2024

nice, my pardon, I didnt check the code.....

No worries, this issue is a good reminder to not forget this, so thanks for creating this!

@golles golles added the enhancement New feature or request label Mar 11, 2024
@golles golles linked a pull request Mar 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants