Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API provides hourly neerslag in mm, yet reported incorrectly in HA as % #126

Closed
1 task done
nonplusnl opened this issue Feb 29, 2024 · 3 comments · Fixed by #127
Closed
1 task done

API provides hourly neerslag in mm, yet reported incorrectly in HA as % #126

nonplusnl opened this issue Feb 29, 2024 · 3 comments · Fixed by #127
Labels
bug Something isn't working

Comments

@nonplusnl
Copy link

Did you read the instructions?

The problem

The Weerlive API reports neerslag as % per day, but in mm per hour. However, the KNMI integration appears to report also the hourly neerslag as %, not as mm.
How to reproduce: when configuring a weather card to show precipitation probability, the card shows the numbers reported by the API, appended by "%" instead of "mm". When configuring weather card to report precipitation amount, the card does not report anything.

Integration version

2.0.0

Home Assistant version

core-2024.2.5

Python version

3.12

Home Assistant log

No response

Diagnostics

No response

Additional information

No response

@golles
Copy link
Owner

golles commented Feb 29, 2024

Thanks for reporting!

The Weerlive API reports neerslag as % per day, but in mm per hour. However, the KNMI integration appears to report also the hourly neerslag as %, not as mm.

I've got a PR with a fix ready that should set the correct value for hourly forecasts, please test

How to reproduce: when configuring a weather card to show precipitation probability, the card shows the numbers reported by the API, appended by "%" instead of "mm". When configuring weather card to report precipitation amount, the card does not report anything.

How do you configure a (which?) weather card to show precipitation amount?

@nonplusnl
Copy link
Author

nonplusnl commented Feb 29, 2024

Thanks!
I am using this weather card via HACS: https://github.com/mlamberts78/weather-chart-card
It allows to show precipitation in either probability or "rainfall" (amount).
Same applies to this HACS-provided one: https://github.com/decompil3d/lovelace-hourly-weather

Will test at home tonight

@nonplusnl
Copy link
Author

Check, the fix works, thanks!
Below you see precipitation in mm for hourly forecasts (in two different weather cards), and in the bottom card, the daily forecast where Weerlive provides probabilities
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants