New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Fatal/Fatalf call os.Exit ? #14

Open

matthewkmayer opened this issue Dec 29, 2021 · 0 comments

matthewkmayer commented Dec 29, 2021

The built-in Go logger exits after writing logs from a call to Fatal or Fatalf:

The Fatal functions call os.Exit(1) after writing the log message

Ledger logs at the Fatal level but doesn't exit. This difference in behavior can lead to misunderstandings about what the program will do.

Should ledger follow the same behavior as the standard Go logger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment