Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor block definitions patched in scratch-gui/src/lib/blocks.js #28

Open
gonfunko opened this issue Apr 18, 2024 · 1 comment
Open
Assignees

Comments

@gonfunko
Copy link
Owner

The scratch-gui package patches/overrides a number of block definitions in src/lib/blocks.js, generally when they need dynamic state depending on the state of the VM. We should likely do one of the following:

  • Remove the body of the block definitions in scratch-blocks, since they're being overwritten
  • Move the dynamic bits out of scratch-gui and into scratch-blocks
  • Perhaps something else?
@cwillisf
Copy link

I'd lean toward "Move the dynamic bits out of scratch-gui and into scratch-blocks" as long as the implementation effort is reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants