Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve block comment IDs when loading from saved file #84

Open
gonfunko opened this issue Jul 11, 2024 · 1 comment
Open

Preserve block comment IDs when loading from saved file #84

gonfunko opened this issue Jul 11, 2024 · 1 comment

Comments

@gonfunko
Copy link
Owner

Currently we initialize block comment IDs to a UUID, but in cases where a saved project is loaded this will cause problems with the VM, because the VM associates comments with their saved IDs, but we'll be sending comment events with the new random UUIDs. This may be more straightforward to address on the VM side by e.g. rewriting the comment IDs the VM stores in its lookup table to be $(BLOCK_ID)_comment or the like.

@cwillisf
Copy link

As long as project file compatibility works correctly in both directions -- new can load old projects AND old can load new projects -- I'm OK with changing the runtime format for these IDs. That "as long as" might be doing a lot of work there, though...? Let me know if it makes sense to work together on this one or meet to talk it through in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants