Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad Release #41

Open
ethanluoyc opened this issue Jul 6, 2023 · 7 comments · May be fixed by #42
Open

Launchpad Release #41

ethanluoyc opened this issue Jul 6, 2023 · 7 comments · May be fixed by #42

Comments

@ethanluoyc
Copy link
Contributor

ethanluoyc commented Jul 6, 2023

Hi Launchpad Team,

Thanks for trying to help us with the #32, however, I don't think we have a release for the new TF version. Both the nightly and stable versions?

I am currently using a wheel built from a source as mentioned in #30 (comment). There are some additional fixes that seem to be required to work with TF 2.12.0. I am happy to create a PR if that is preferred (but maybe it's easier to update from internal). There seem to be some upgrades needed in terms of how to handle absl Status and tsl Status otherwise things are straightforward.

The update is quite useful as it is currently blocking using JAX agents in dm-acme at HEAD. dm-acme@HEAD now uses jax>0.4.3 which is incompatible with the TF/TFP version used in Acme.

@ddmbr what do you think?

@ddmbr
Copy link
Collaborator

ddmbr commented Jul 10, 2023

Hi! I'll try to make a release soon. Which version of TF and Reverb do you need?

@ethanluoyc
Copy link
Contributor Author

Thank you! I think maybe targeting TF 2.12.0 would be good (this is the version of TF that is used by the latest reverb update).

@hartikainen
Copy link

hartikainen commented Jul 11, 2023

Yeah tensorflow==2.12 or tensorflow==2.13 wheel would be much appreciated. If possible, for python==3.10 🙂

@hartikainen
Copy link

hartikainen commented Jul 20, 2023

reverb just released v0.12.0 which supports tensorflow==2.13. If the latest launchpad release is still in progress, it would be really neat to get it published with tensorflow==2.13.

@ddmbr
Copy link
Collaborator

ddmbr commented Jul 20, 2023

Ran into issues, still trying...

@ethanluoyc
Copy link
Contributor Author

Would you like to take a look at https://github.com/ethanluoyc/launchpad/tree/v0.5.2rc0+1 ? This is a working build for TF 2.12. I can create PR if that helps with importing the code for doing things internally.

@ddmbr
Copy link
Collaborator

ddmbr commented Jul 20, 2023

Thank you! I'll try your fix later

@ethanluoyc ethanluoyc linked a pull request Aug 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants