Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 Compatibility Errors #1075

Closed
jcraisbeck opened this issue Sep 26, 2024 · 1 comment
Closed

Python 3.8 Compatibility Errors #1075

jcraisbeck opened this issue Sep 26, 2024 · 1 comment

Comments

@jcraisbeck
Copy link

Hello,

Sorry if this is poorly formatted, I don't often submit issues like this.

There are three files in contrib that aren't fully compatible with Python 3.8 because of issues with typing, because objects that should be initialized as a Tuple are initialized as tuples, and in once case because Tuple isn't in the initial import from typing. Could this be fixed in the following files?

dadapt_adamw.py,
combine.py,
prodigy.py.

@vroulet
Copy link
Collaborator

vroulet commented Sep 26, 2024

Hello @jcraisbeck
No worries, issues are welcome.
Indeed optax only supports python>=3.9 and indeed the only unsupported items should be the typings (I believe such an issue may appear in many files).
We prefer to align with most recent practices in python and for this reason we removed support for python 3.8.
Could you explain why you can't use python>=3.9?
Thanks !

@fabianp fabianp closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants