Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Theming: Android Basics with Compose #103

Open
gloglo1980 opened this issue Aug 30, 2024 · 1 comment
Open

Material Theming: Android Basics with Compose #103

gloglo1980 opened this issue Aug 30, 2024 · 1 comment

Comments

@gloglo1980
Copy link

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-material-theming?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-3-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-material-theming#3

In which task and step of the codelab can this issue be found?
Add color palette to theme

Describe the problem
Insufficient information:
"On the Material Theme Builder page, there is the option to click the Export button to download a Color.kt file and Theme.kt file with the custom theme you created in the Theme Builder."
There is no export button on the material theme builder page. You have to click the little "+" in the top right corner, which opens a thingy with the export button at the bottom.

@gloglo1980
Copy link
Author

It's not made clear that we will not be exporting a Color.kt file but rather editing the project's existing Color.kt file.
The wording in the codelab can also be taken to mean we should export a Color.kt file from Material Theme Builder and edit that.

On the Material Theme Builder page, there is the option to click the Export button to download a Color.kt file and Theme.kt file with the custom theme you created in the Theme Builder.

This will work to add the custom theme we create to your app. However, because the generated Theme.kt file does not include the code for dynamic color which we will cover later in the codelab, copy the files in. (here you could add for clarity "we will not be exporting these files, instead we will be editing the project's existing files")

Open the Color.kt file and replace the contents with the code below to copy in the new color scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant