Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Support CTAP 2.1 #16

Open
kaczmarczyck opened this issue Sep 17, 2020 · 10 comments
Open

Support CTAP 2.1 #16

kaczmarczyck opened this issue Sep 17, 2020 · 10 comments
Assignees
Labels
enhancement New feature or request tracking List of things to do

Comments

@kaczmarczyck
Copy link
Contributor

The test tool currently supports commands from version 2.0. GetInfo informs about supported versions.

For old commands, tests should differentiate between authenticator versions.
For new commands, tests should only run if an authenticator claims it is compatible.

@kaczmarczyck kaczmarczyck added the enhancement New feature or request label Sep 17, 2020
@kaczmarczyck kaczmarczyck self-assigned this Sep 17, 2020
@kaczmarczyck kaczmarczyck added the tracking List of things to do label Sep 25, 2020
@geofli
Copy link

geofli commented Apr 6, 2021

any update about supporting CTAP 2.1?

@kaczmarczyck
Copy link
Contributor Author

Review draft 3 looks like it's going to closely resemble the final version. Also, I almost finished the implementation for OpenSK (see this issue). I'll start working on the test tool soon.

@dangfan
Copy link

dangfan commented Sep 20, 2022

Hi there, the PS version has been published for a while. Is there any update about supporting CTAP 2.1? Thanks!

@kaczmarczyck
Copy link
Contributor Author

The CTAP code itself has worked in all my tests. We are working on a few other feature before we could do a release. If you want to test CTAP 2.1 support, feel free to try our develop branch and we welcome your feedback!

@dangfan
Copy link

dangfan commented Sep 21, 2022

Thank you for the reply. Unfortunately, I don't see the develop branch.
Also, I noticed that there is an AuthenticatorCredentialManagementPositiveTest function in fido_commands.cc, but I cannot find an invocation to it. Should I add such tests in GetTests?
Thanks!

@kaczmarczyck
Copy link
Contributor Author

Oh nevermind my last comment, I was working on OpenSK before and didn't realize that this is my Test Tool.

We don't have tests for 2.1 here yet. If you want to add any, feel free to.

@dangfan
Copy link

dangfan commented Sep 21, 2022

Okay. Thanks a lot!

@szszszsz
Copy link

Hey @kaczmarczyck !

  1. I saw there are 10 or so CTAP 2.1 tests. Any plans on extending that?
  2. Do you plan to support CTAP 2.2? If so, do you have any rough time plan? I do not see any mentions of it on OpenSK project, which I understand would be required to proceed on this.

@kaczmarczyck
Copy link
Contributor Author

Hi!
Support for newer Test Tool versions is on hold. We will look into testing for 2.1 or 2.2 when OpenSK releases its next version.

There is no timeline for that yet. I don't think the difference between 2.1 and 2.2 is as big as from 2.0 to 2.1, so I don't expect CTAP to be a major blocker. There are other open questions for a new OpenSK release though.

@szszszsz
Copy link

All clear, thank you for the update!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request tracking List of things to do
Projects
None yet
Development

No branches or pull requests

4 participants