Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot should not add google/android-fhir group as reviewers to its PRs #2585

Open
vorburger opened this issue Jun 24, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file effort:small Small effort - 2 days help wanted Extra attention is needed P2 Medium priority issue type:process Create or improve processes

Comments

@vorburger
Copy link
Member

This is a follow-up to #2320:

On e.g. #2582, Dependabot should not automatically add google/android-fhir group as reviewers to its PRs.

@vorburger vorburger added help wanted Extra attention is needed type:process Create or improve processes effort:small Small effort - 2 days dependencies Pull requests that update a dependency file labels Jun 24, 2024
@vorburger vorburger self-assigned this Jun 24, 2024
@vorburger
Copy link
Member Author

---------- Forwarded message ---------
From: Michael Vorburger <>
Date: Mon, Jun 24, 2024 at 2:02 PM
Subject: Unknown owner on line 11: make sure @santosh-pingle exists and has write access to the repository
To: [email protected]

Hello GitHub Support,

https://github.com/google/android-fhir/blob/master/CODEOWNERS (currently) shows:

Unknown owner on line 11: make sure @santosh-pingle exists and has write access to the repository

But this appears to be a bug at GitHub, because https://github.com/santosh-pingle does exist...

#2582 initially got assigned to the 3 other OWNERS, and then afterwards got assigned to santosh-pingle and @google/android-fhir - which we don't want; how does Dependabot determine those additional reviewers? How can we make it not add @google/android-fhir anymore? It's not configured in https://github.com/google/android-fhir/blob/master/.github/dependabot.yaml, so I don't understand what makes it do that.

Tracked as #2585.

Tx,
M.

@vorburger
Copy link
Member Author

[email protected] bounces, so:

#2586 created re. Unknown owner on line 11 of CODEOWNERS.

https://github.com/orgs/community/discussions/129619 started re. Dependabot reviewers.

@santosh-pingle santosh-pingle added the P2 Medium priority issue label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file effort:small Small effort - 2 days help wanted Extra attention is needed P2 Medium priority issue type:process Create or improve processes
Projects
Status: New
Development

No branches or pull requests

2 participants