Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolating Room Components with hapi dependencies #2599

Open
MJ1998 opened this issue Jul 5, 2024 · 1 comment
Open

Isolating Room Components with hapi dependencies #2599

MJ1998 opened this issue Jul 5, 2024 · 1 comment

Comments

@MJ1998
Copy link
Collaborator

MJ1998 commented Jul 5, 2024

Describe the Issue

Room components(@database, @dao, @entity) should be completely independent of hapi dependencies.
The primary reason is to maintain a better code structure as the implementation of the DAOs are created by room library.
This may help in support multiple FHIR versions (R4, R5) in future.
Another reason is to ensure our implementation is future-proof for Room's Kotlin Multiplatform support, introduced in version 2.7.0-alpha01 on May 1, 2024, and currently at version 2.7.0-alpha04.

Also FYI
Migrate to KMP Room - https://developer.android.com/training/data-storage/room/room-kmp-migration

Would you like to work on the issue?

@MJ1998 MJ1998 changed the title Isolating Room Components for Future Room KMP Support Isolating Room Components with hapi dependencies Jul 8, 2024
@jingtang10
Copy link
Collaborator

Room components(@database, @dao, @entity) should be completely independent of hapi dependencies.

Can you elaborate what you mean by this? Our database API is a way for us to say "save this FHIR resource in our db" or "load this FHIR resource from our db", if it doesn't have dependency on HAPI FHIR what will the APIs do at all?

Regarding migration to kmp, first of all it's a big queestion if/when, but let's forget about that for a moment, how does this help with the migration? Is there anything in the migration guide you linked not doable or at least made more complicated by HAPI dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

2 participants