Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reindexing old data whenever new custom SearchParameter are added #2770

Open
LZRS opened this issue Jan 16, 2025 · 2 comments
Labels
effort:medium Medium effort - 3 to 5 days P2 Medium priority issue

Comments

@LZRS
Copy link
Collaborator

LZRS commented Jan 16, 2025

Is your feature request related to a problem? Please describe.
Whenever custom SearchParameters are changed, new data saved/updated to the DB would have their fields indexed but previously saved data wouldn't. Searches performed would then lead to partial results.
Workarounds for this have been getting all currently saved resources and re-saving them back to the DB

Describe the solution you'd like
Have an interface method that could configure reindexing of old data

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Relates to #2769

Would you like to work on the issue?
Yes

@MJ1998
Copy link
Collaborator

MJ1998 commented Jan 19, 2025

This is not so trivial. What is the priority for this feature?

Also on first thoughts, i guess this can require search-param-state management (versioning and/or db table). Any thoughts on this or other solutions in mind @LZRS ?

@LZRS
Copy link
Collaborator Author

LZRS commented Jan 20, 2025

This is not so trivial. What is the priority for this feature?

I'd say it's of medium priority at the moment

Also on first thoughts, i guess this can require search-param-state management (versioning and/or db table). Any thoughts on this or other solutions in mind @LZRS ?

Yeah, I was also thinking along the same lines, to use a db table for the state management. But looking at other implementations such as this one, maybe it might be easier to just add a FhirEngine reindex interface method that would take some parameters and schedule a reindex job.

@MJ1998 MJ1998 added P2 Medium priority issue effort:medium Medium effort - 3 to 5 days labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Medium effort - 3 to 5 days P2 Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants