Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The blockly API for function calls needs to be updated #137

Open
HenTaiCJN opened this issue Jan 7, 2025 · 0 comments
Open

The blockly API for function calls needs to be updated #137

HenTaiCJN opened this issue Jan 7, 2025 · 0 comments

Comments

@HenTaiCJN
Copy link

HenTaiCJN commented Jan 7, 2025

"@blockly/keyboard-navigation": "^0.6.12",
"blockly": "^11.2.0"

navigation_controller.js

  toolboxHandler(shortcut) {
    if (!this.selectedItem_) {
      return false;
    }
    switch (shortcut.name) {
      case Constants.SHORTCUT_NAMES.PREVIOUS:
        return this.selectPrevious_();
      case Constants.SHORTCUT_NAMES.OUT:
        return this.selectParent_();
      case Constants.SHORTCUT_NAMES.NEXT:
        return this.selectNext_();
      case Constants.SHORTCUT_NAMES.IN:
        return this.selectChild_();
      default:
        return false;
    }
  }

The selectPrevious_, selectParent_, selectNext_, and selectChild_ functions mentioned above are no longer available. In the new version of blockly, the function names have been updated and the trailing "_" has been removed.
Both this repository and @blockly/keyboard-navigation need to be updated.

In addition, there should be other places that need to be updated, but there is no error log output, so I can't locate it. So I decided to temporarily roll back blockly to version 11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant