Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design unified object for keyboard shortcuts and context menu actions #155

Open
rachel-fenichel opened this issue Jan 16, 2025 · 0 comments

Comments

@rachel-fenichel
Copy link
Contributor

As part of #130, we need to register all keyboard shortcuts (that should be accessible from context menus) as context menu items, with appropriate callbacks and preconditions.

Since the shortcuts are all defined in as an array of ShortcutRegistry.KeyboardShortcut items in navigation_controller.ts, it would be best to use that as the source of truth and write a helper to do the mapping, which is called once.

Later when we add a different scope to the context menu system we can update this helper to add the correct scope.

@rachel-fenichel rachel-fenichel changed the title Register all keyboard shortcut items as context menu items Register some keyboard shortcut items as context menu items Jan 17, 2025
@rachel-fenichel rachel-fenichel changed the title Register some keyboard shortcut items as context menu items Design unified object for keyboard shortcuts and context menu actions Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant