You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of #130, we need to register all keyboard shortcuts (that should be accessible from context menus) as context menu items, with appropriate callbacks and preconditions.
Since the shortcuts are all defined in as an array of ShortcutRegistry.KeyboardShortcut items in navigation_controller.ts, it would be best to use that as the source of truth and write a helper to do the mapping, which is called once.
Later when we add a different scope to the context menu system we can update this helper to add the correct scope.
The text was updated successfully, but these errors were encountered:
rachel-fenichel
changed the title
Register all keyboard shortcut items as context menu items
Register some keyboard shortcut items as context menu items
Jan 17, 2025
rachel-fenichel
changed the title
Register some keyboard shortcut items as context menu items
Design unified object for keyboard shortcuts and context menu actions
Jan 29, 2025
As part of #130, we need to register all keyboard shortcuts (that should be accessible from context menus) as context menu items, with appropriate callbacks and preconditions.
Since the shortcuts are all defined in as an array of
ShortcutRegistry.KeyboardShortcut
items innavigation_controller.ts
, it would be best to use that as the source of truth and write a helper to do the mapping, which is called once.Later when we add a different scope to the context menu system we can update this helper to add the correct scope.
The text was updated successfully, but these errors were encountered: