Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create flag to enable visiting stack nodes #179

Closed
cpcallen opened this issue Jan 28, 2025 · 0 comments · Fixed by #199
Closed

Create flag to enable visiting stack nodes #179

cpcallen opened this issue Jan 28, 2025 · 0 comments · Fixed by #199
Assignees

Comments

@cpcallen
Copy link
Contributor

Create a flag, settable by query parameter, to enable/disable visiting stack nodes other than unconnected next nodes.

@cpcallen cpcallen self-assigned this Jan 28, 2025
@cpcallen cpcallen added this to the micro:bit UX testing milestone Jan 28, 2025
@cpcallen cpcallen moved this to In Progress in Blockly Accessibility Feb 10, 2025
cpcallen added a commit that referenced this issue Feb 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Introduce getOptions function (replacing most of loadScenario)
to parse query parameters for the scenario, renderer and
stackConnection options and update the form controls to match
(after a short delay so that Chrome does not later restore
incorrect form state when page navigation has occurred).

N.B.: Because checkbox inputs do not send any parameter when
not checked, it is not possible (without considerable extra
trouble) to have a checkbox default to checked, so the
checkbox for stackConnections is inverted from the option
and is labelled accordingly.

Fixes #179.
cpcallen added a commit that referenced this issue Feb 18, 2025
Introduce getOptions function (replacing most of loadScenario)
to parse query parameters for the scenario, renderer and
stackConnection options and update the form controls to match
(after a short delay so that Chrome does not later restore
incorrect form state when page navigation has occurred).

N.B.: Because checkbox inputs do not send any parameter when
not checked, it is not possible (without considerable extra
trouble) to have a checkbox default to checked, so the
checkbox for stackConnections is inverted from the option
and is labelled accordingly.

Fixes #179.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Blockly Accessibility Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant