Typescript error for dropdown field

[pachtymi]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

When appending a dropdown field I get:

Argument of type 'FieldDropdown' is not assignable to parameter of type 'string | Field<string | undefined>'.
  Type 'FieldDropdown' is not assignable to type 'Field<string | undefined>'.
    Types of property 'validator_' are incompatible.
      Type 'FieldValidator<string> | null' is not assignable to type 'FieldValidator<string | undefined> | null'.
        Type 'FieldValidator<string>' is not assignable to type 'FieldValidator<string | undefined>'.
          Types of parameters 'newValue' and 'newValue' are incompatible.
            Type 'string | undefined' is not assignable to type 'string'.
              Type 'undefined' is not assignable to type 'string'.

The code, which is straight from the docs:

this.appendDummyInput()
                .appendField('drop down:')
                .appendField(new Blockly.FieldDropdown([
                    ['first item', 'ITEM1'],
                    ['second item', 'ITEM2']
                ]), 'FIELDNAME');

Reproduction steps

1. Attempt to put a new FieldDropdown into an appendField

Stack trace

No response

Screenshots

No response

Browsers

No response

[pachtymi]

A workaround I can do is

this.appendDummyInput()
                .appendField('drop down:')
                .appendField(new Blockly.FieldDropdown([
                    ['first item', 'ITEM1'],
                    ['second item', 'ITEM2']
                ]) as Blockly.Field, 'FIELDNAME');

But this is less than ideal.

[BeksOmega]

Looks like this might be a change with typescript 5.3 #7713

[BeksOmega]

Christopher added notes

• chore(deps): Bump typescript from 5.2.2 to 5.3.3 #7713 (comment)
• chore(deps): Bump typescript from 5.2.2 to 5.3.3 #7713 (comment)

[maribethb]

@btw17 would you be interested in looking at this one next? it's something we wanted to fix this quarter but haven't been able to prioritize. there's some more details in the PR comments beka linked above

[btw17]

@btw17 would you be interested in looking at this one next? it's something we wanted to fix this quarter but haven't been able to prioritize. there's some more details in the PR comments beka linked above

Looks interesting - I'll take a look @maribethb!

[btw17]

Found the issue! Thank you for your patience with this - wasn't able to work on this the last few weeks.

The fix was actually rather simple - just needed to update doClassValidation_ in FieldDropdown.