Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing information enters the translations #1982

Closed
mgeisler opened this issue Apr 12, 2024 · 2 comments · Fixed by #2005
Closed

Timing information enters the translations #1982

mgeisler opened this issue Apr 12, 2024 · 2 comments · Fixed by #2005
Assignees

Comments

@mgeisler
Copy link
Collaborator

Hi @djmitche, I noticed in #1974 that the timing information enters the translations. This is in some sense working as intended, but I fear that it creates extra work for the translators.

On Welcome to Day 1, as an example, if we would format

as a table

Page
Welcome 5 minutes
Hello, World 15 minutes
Types and Values 40 minutes
Control Flow Basics 40 minutes

then the page titles would be extracted on their own — and they would match the title we already extract from each page. So it would reuse the translation for the page, which is kind of neat 🙂

I don't have a good idea for how to include the page link like in the current formatting. We include the link in the translatable message, so this would defeat the attempt at unifying the message here with the page title.

@djmitche
Copy link
Collaborator

The links probably aren't that useful -- they're available in the sidebar as well. We could just omit them.

To be clear, then, the suggestion is to format the schedule as a table rather than a list?

@djmitche djmitche self-assigned this Apr 12, 2024
@mgeisler
Copy link
Collaborator Author

The links probably aren't that useful -- they're available in the sidebar as well. We could just omit them.

Good point!

To be clear, then, the suggestion is to format the schedule as a table rather than a list?

Yeah, it was an idea for how to avoid generating extra translation work: tables are translated cell-by-cell, so if the content of a cell matches an existing heading, there is no extra work for our translators!

djmitche added a commit that referenced this issue Apr 19, 2024
This is more friendly to translation (as it can share the translation of
the title).

This fixes #1982.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants