Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appear emojis in code blocks #329

Open
skydoves opened this issue Feb 3, 2022 · 2 comments
Open

Appear emojis in code blocks #329

skydoves opened this issue Feb 3, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@skydoves
Copy link

skydoves commented Feb 3, 2022

Description

If code blocks include :${value}: string, emojis appear in code blocks like the following screenshots:

Screen Shot 2022-02-03 at 10 43 08 AM

Screen Shot 2022-02-03 at 10 43 35 AM

The full dependency sentence should be like the below:

implementation "com.github.skydoves:balloon:1.4.1"

I guess rendering emojis for the markdown content should filter the code blocks.

Relevant Links

Thanks, Google Dev Library team for building awesome projects!

@samtstern
Copy link
Contributor

@skydoves thanks for reporting this! This is an interesting edge case. I guess we'll have to do the emoji replacement step on the final HTML so that we can know if it's inside a <pre> or not.

@samtstern samtstern added bug Something isn't working help wanted Extra attention is needed labels Feb 3, 2022
@thatfiredev
Copy link
Member

Fixed in #335
This issue can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants