[2.29.1] JPMS Module metadata was removed

[ben-manes]

I tried upgrading to 2.29.0 / 2.29.1 and it fails due to

> Task :caffeine:compileJava FAILED
/Users/ben/projects/caffeine/caffeine/src/main/java/module-info.java:6: error: module not found: com.google.errorprone.annotations
  requires static com.google.errorprone.annotations;

I tried to follow the previous validation steps:

# 2.28.0: module-info, not in manifest
$ wget -q https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.28.0/error_prone_annotations-2.28.0.jar
$ unzip -q error_prone_annotations-2.28.0.jar META-INF/MANIFEST.MF
$ grep Automatic-Module-Name META-INF/MANIFEST.MF
$ unzip -q error_prone_annotations-2.28.0.jar META-INF/versions/9/module-info.class
$ javap -v META-INF/versions/9/module-info.class | grep "open module"
open module [email protected]

# 2.29.1: no module definition
$ wget -q https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.29.1/error_prone_annotations-2.29.1.jar
$ unzip -q error_prone_annotations-2.29.1.jar META-INF/MANIFEST.MF
$ grep Automatic-Module-Name META-INF/MANIFEST.MF
$ unzip -q error_prone_annotations-2.29.1.jar META-INF/versions/9/module-info.class
caution: filename not matched:  META-INF/versions/9/module-info.class

The module-info.java file was removed in Handle static members in inner classes in *CanBeStatic checks (39609bf) which seems unrelated.

[cpovirk]

Well, that's weird.

As best I can tell from poking around a little, there may have been some change in a service that Copybara delegates to. I have a repro command that I'll share with the Copybara team after I get back from an appointment.

[cushon]

Thanks Chris! You got farther than I did investigating, please loop me in when you share the repro.

[cpovirk]

#4482 has restored the file. Over to @cushon for a release.

[cushon]

I released the fix in https://github.com/google/error-prone/releases/tag/v2.29.2