From 8e6a3ee7fa32f220b0a8dfb1bdf2552da1e8b872 Mon Sep 17 00:00:00 2001 From: Jonathan Metzman Date: Tue, 24 Sep 2024 14:17:12 -0400 Subject: [PATCH 1/3] Calculate branch coverage correctly --- experiment/measurer/coverage_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experiment/measurer/coverage_utils.py b/experiment/measurer/coverage_utils.py index 42ca57385..7a49350d7 100644 --- a/experiment/measurer/coverage_utils.py +++ b/experiment/measurer/coverage_utils.py @@ -283,7 +283,7 @@ def generate_json_summary(coverage_binary, expect_zero=False) return result - +# Test def extract_covered_branches_from_summary_json(summary_json_file): """Returns the covered branches given a coverage summary json file.""" covered_branches = [] From 06d80e3ed5386bd4e0a8aef8b2014c824ad2b50b Mon Sep 17 00:00:00 2001 From: Jonathan Metzman Date: Tue, 24 Sep 2024 14:21:00 -0400 Subject: [PATCH 2/3] dummy --- service/gcbrun_experiment.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/service/gcbrun_experiment.py b/service/gcbrun_experiment.py index f19ab493d..c4ac1d207 100644 --- a/service/gcbrun_experiment.py +++ b/service/gcbrun_experiment.py @@ -91,6 +91,8 @@ def main(): return 0 return 1 +# DUMMY + if __name__ == '__main__': sys.exit(main()) From 767549036157e794656ad36e73915f34d54803c4 Mon Sep 17 00:00:00 2001 From: Jonathan Metzman Date: Tue, 24 Sep 2024 14:21:35 -0400 Subject: [PATCH 3/3] fix --- experiment/measurer/coverage_utils.py | 1 + service/gcbrun_experiment.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/experiment/measurer/coverage_utils.py b/experiment/measurer/coverage_utils.py index 7a49350d7..59bfeb67f 100644 --- a/experiment/measurer/coverage_utils.py +++ b/experiment/measurer/coverage_utils.py @@ -283,6 +283,7 @@ def generate_json_summary(coverage_binary, expect_zero=False) return result + # Test def extract_covered_branches_from_summary_json(summary_json_file): """Returns the covered branches given a coverage summary json file.""" diff --git a/service/gcbrun_experiment.py b/service/gcbrun_experiment.py index c4ac1d207..95ccb7787 100644 --- a/service/gcbrun_experiment.py +++ b/service/gcbrun_experiment.py @@ -91,8 +91,8 @@ def main(): return 0 return 1 -# DUMMY +# DUMMY if __name__ == '__main__': sys.exit(main())