Include path to gtest.h in GTMGoogleTestRunner.mm #407
Comments
hiroyuki-komatsu
added a commit
to google/mozc
that referenced
this issue
May 12, 2023
* Suppress the CI error on GitHub Actions. * To address the root cause we probably need to update the upstream of google-toolbox-for-mac. + google/google-toolbox-for-mac#407 #codehealth PiperOrigin-RevId: 531506258
hiroyuki-komatsu
added a commit
to google/mozc
that referenced
this issue
May 12, 2023
*** Reason for rollback *** cl/531511096 addresses the issue in a proper way. *** Original change description *** Add "manual" to mozc_objc_test.macos_unit_test. * Suppress the CI error on GitHub Actions. * To address the root cause we probably need to update the upstream of google-toolbox-for-mac. + google/google-toolbox-for-mac#407 #codehealth *** PiperOrigin-RevId: 531512979
|
Go ahead with a patch for the second one, since I believe that's what the repo is called these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
UnitTesting/GTMGoogleTestRunner.mm has the following code to include
gtest.h.However, the actual path is
(third_party/googletest/)googletest/include/gtest/gtest.h.Would you change the include path to either of the following paths?
or
FYI. google/mozc is the project that needs this change.
https://github.com/google/mozc/blob/master/src/WORKSPACE.bazel#L142
Thank you!
The text was updated successfully, but these errors were encountered: