Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test jimfs in a JPMS world #97

Open
cpovirk opened this issue Oct 4, 2019 · 2 comments
Open

Test jimfs in a JPMS world #97

cpovirk opened this issue Oct 4, 2019 · 2 comments
Labels
P3 type=defect Bug, not working as expected

Comments

@cpovirk
Copy link
Member

cpovirk commented Oct 4, 2019

I have fears that it might not work with modules on, since it uses ServiceLoader:
http://openjdk.java.net/projects/jigsaw/spec/sotms/#services

I assume that our tests either don't use modules at all or uses them but with a backdoor to directly access the code under test. We would have to look into this more.

@cpovirk cpovirk added type=defect Bug, not working as expected P3 labels Oct 4, 2019
@cpovirk
Copy link
Member Author

cpovirk commented Oct 4, 2019

I have some other notes in internal bug 142067432.

@ascopes
Copy link
Contributor

ascopes commented Nov 8, 2022

For what it is worth, I am using Jimfs via JPMS already in my project.

I have yet to have any issues with using it with modules. It appears that the module based service provider mechanisms are just an optional alternative to the service files used in Java 8 and older. They still work as expected under Java 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 type=defect Bug, not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants