Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct linking by alias #760

Open
andrewpollock opened this issue Sep 30, 2022 · 9 comments
Open

Support direct linking by alias #760

andrewpollock opened this issue Sep 30, 2022 · 9 comments
Labels
backlog Important but currently unprioritized enhancement New feature or request frontend Frontend Infrastructure

Comments

@andrewpollock
Copy link
Contributor

[redacted] linking to https://osv.dev/vulnerability/GHSA-jfh8-c2jp-5v3q for Log4Shell.

I wish it was possible to link to https://osv.dev/vulnerability/CVE-2021-44228

@andrewpollock andrewpollock added enhancement New feature or request frontend Frontend Infrastructure labels Sep 30, 2022
@oliverchang
Copy link
Collaborator

I wonder what the behaviour should be if there are multiple that link to the same alias.

@oliverchang
Copy link
Collaborator

I wonder what the behaviour should be if there are multiple that link to the same alias.

Oh, maybe we can redirect to the list page instead with the filter set to the alias in that case.

@andrewpollock
Copy link
Contributor Author

I see in the case of https://osv.dev/vulnerability/GHSA-jfh8-c2jp-5v3q, it has three aliases, two of which link to other entries that cite each other. It's basically the (current) lack of an entry for the CVE that makes this not work.

I'm thinking we'd call this "done" once we're successfully importing the CVE record from the NVD?

@andrewpollock
Copy link
Contributor Author

I'm thinking we'd call this "done" once we're successfully importing the CVE record from the NVD?

Are there other data sources than CVE that can get referenced as an alias without currently being imported?

@oliverchang
Copy link
Collaborator

I see in the case of https://osv.dev/vulnerability/GHSA-jfh8-c2jp-5v3q, it has three aliases, two of which link to other entries that cite each other. It's basically the (current) lack of an entry for the CVE that makes this not work.

I'm thinking we'd call this "done" once we're successfully importing the CVE record from the NVD?

Yes, that's one approach, but it does introduce questions around duplicates even if we can link them via aliases.

Are there other data sources than CVE that can get referenced as an alias without currently being imported?

Yes, there is no requirement that anything in aliases are OSV formatted. There are going to be things like SNYK-, RHSA- in there.

@zahraaalizadeh
Copy link
Contributor

Is this issue still applicable or a matter of concern? @oliverchang

@another-rex
Copy link
Contributor

I believe we do still want this, though the need for it is greatly reduced now that we are importing git CVE entries directly. E.g. The example given by Andrew is no longer an issue, since it now links to the GIT entry.

@andrewpollock
Copy link
Contributor Author

This is essentially search-by-alias functionality, when the aliased record doesn't actually exist in OSV.dev.

e.g. when https://osv.dev/GHSA-9p26-698r-w4hx aliases CVE-2024-23650 and CVE-2024-23650 doesn't exist in OSV.dev.

Trying to go to https://OSV.dev/CVE-2024-23650 results in a 404.

There's an opportunity to search the AliasGroup in Data Store, determine that GHSA-9p26-698r-w4hx and GO-2024-2492 are existant aliases for this and present an interstitial page (or search results) that links to these instead of serving a 404.

Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 28, 2024
@andrewpollock andrewpollock added the backlog Important but currently unprioritized label Jul 29, 2024
@oliverchang oliverchang removed the stale The issue or PR is stale and pending automated closure label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Important but currently unprioritized enhancement New feature or request frontend Frontend Infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants