-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider re-exporting package:fake_async
and package:clock
and removing custom impls
#590
Comments
Good question -- FakeAsync was originally created here but later broken out into its own package. At one point there definitely were are a few differences but if we haven't yet, we should kill those off. It seems reasonable to either re-export them or simply deprecate the quiver version and redirect users to FakeAsync in the documentation. Will take a look. |
Note that I have a PR out to fake_async to add the |
I realized that this is actually likely a blocker for migrating flutter_test off of quiver - there is at least one test internally which grabs the clock from flutter_test and passes it to something that expects a quiver Clock. If we just re-export package:clock that solves the problem though. |
You can pretty easily make a quiver clock from a package:clock clock ( |
The I just triggered such a bug in an internal test that still uses The fake-async code in this repo should never be used, and removing it would be the best solution. |
We currently maintain duplicate implementations of
FakeAsync
andClock
in thefake_async
andclock
packages. I haven't done a full evaluation but they seem almost identical.Can we simply re-export those packages from here instead to keep them in sync?
We could at the same time deprecate the public entrypoints for those libraries and point at those packages.
The text was updated successfully, but these errors were encountered: