Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AdsPAX Dashboard Reporting Widget (Pax Pilot V2) #10219

Open
1 task done
10upsimon opened this issue Feb 13, 2025 · 4 comments
Open
1 task done

Remove AdsPAX Dashboard Reporting Widget (Pax Pilot V2) #10219

10upsimon opened this issue Feb 13, 2025 · 4 comments
Assignees
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Feature New feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Feb 13, 2025

Feature Description

With the Ads PAX feature being rolled out for a Pilot V2 round, the need to remove the dashboard reporting widget has been identified. This removal should not be permanent, and therefore the component should remain within the codebase, but simply not registered and rendered against the dashboard.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Ads PAX embedded reporting widget, <PartnerAdsPAXWidget>, should no longer display within the Site Kit dashboard following Ads setup using the PAX setup flow.

Implementation Brief

  • In assets/js/modules/ads/index.js
    • Remove registration of partnerAdsPAX widget, and usage of PartnerAdsPAXWidget component

Test Coverage

  • No updates needed

QA Brief

  • With the adsPax feature flag enabled, setup the Ads PAX module by using a Google account that has Ads account. Go through the steps to create or reuse an old campaign.
  • Verify that the Ads Pax widget does not render on the dashboard without any new errors in the console.
  • Verify that switching to the latest release branch does show the the Ads Pax widget on the dashboard.

Changelog entry

  • Unregister the PartnerAdsPAXWidget widget.
@10upsimon 10upsimon added javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Feature New feature labels Feb 13, 2025
@10upsimon 10upsimon self-assigned this Feb 13, 2025
@binnieshah binnieshah added the Next Up Issues to prioritize for definition label Feb 13, 2025
@10upsimon 10upsimon assigned zutigrm and unassigned 10upsimon Feb 13, 2025
@zutigrm
Copy link
Collaborator

zutigrm commented Feb 13, 2025

AC ✅

@zutigrm zutigrm assigned 10upsimon and unassigned zutigrm Feb 14, 2025
@10upsimon
Copy link
Collaborator Author

@zutigrm IB ✅ , moving to EB.

@10upsimon 10upsimon removed their assignment Feb 14, 2025
@jimmymadon jimmymadon self-assigned this Feb 17, 2025
@binnieshah binnieshah removed the Next Up Issues to prioritize for definition label Feb 19, 2025
@jimmymadon jimmymadon removed their assignment Feb 20, 2025
@kelvinballoo kelvinballoo self-assigned this Feb 24, 2025
@kelvinballoo
Copy link
Collaborator

kelvinballoo commented Feb 24, 2025

QA Update ⚠

Hi @jimmymadon , tested this and the Pax widget will not appear on the SK dashboard.
I do have one observation however. I don't know if it's already being handled under another ticket but here's the issue:

  • If we set up an Ad campaign, we would have the subtle success notification Your Ads campaign was successful set up with the CTA Show me

  • Clicking Show me would dismiss the banner but would not anchor to anywhere.

  • With the Pax widget no longer appearing, this CTA is irrelevant. We should look into removing it, update the messaging or link to somewhere else.

    10219.-.subtle.notification.mov

Other than that, the main thing is verified good. The widget appears under 'latest branch' and will be hidden with 'develop' branch.

10219.-.test.02.ok.mov

@jimmymadon
Copy link
Collaborator

@10upsimon Could you please reply to the query above as I am not sure what the full roadmap is here. Are we going to add another widget in the future or should we modify the "Show me" CTA to be "Got it" as @zutigrm suggested in Slack. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Feature New feature
Projects
None yet
Development

No branches or pull requests

6 participants