Remove signInWithGoogleModule feature flag

[tofumatt]

Feature Description

Now that the signInWithGoogleModule feature flag has been rolled out to 100% of users, we can remove the flag.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The signInWithGoogleModule feature flag should be removed from feature-flags.json and the entire codebase
• Logic that depends on signInWithGoogleModule not being present should be removed
• The signInWithGoogleModule should not appear in the list of feature flags when using the Site Kit Tester Plugin.

Implementation Brief

• Remove feature flag checks from:

  • site-kit-wp/assets/js/modules/sign-in-with-google/index.js

    Line 101 in 73ecd89

    if ( isFeatureEnabled( 'signInWithGoogleModule' ) ) {

  • site-kit-wp/includes/Core/Modules/Modules.php

    Line 186 in 73ecd89

    if ( Feature_Flags::enabled( 'signInWithGoogleModule' ) ) {

• Remove feature flag from story:

  site-kit-wp/assets/js/modules/sign-in-with-google/components/dashboard/SetupSuccessSubtleNotification.stories.js

  Line 55 in 73ecd89

  <WithTestRegistry features={ [ 'signInWithGoogleModule' ] }>

• Remove the feature flag from

  site-kit-wp/feature-flags.json

  Line 10 in 73ecd89

  "signInWithGoogleModule"

Test Coverage

• Update test to exclude feature flag activation here:

  site-kit-wp/tests/phpunit/integration/Core/Modules/ModulesTest.php

  Line 88 in 73ecd89

  public function test_get_available_modules__with_siwg_module_feature_flag_enabled() {

QA Brief

Changelog entry

[eugene-manuilov]

IB ✔

[wpdarren]

@kelvinballoo @mohitwp I suspect the QAB will mention this but just in case, as part of this testing we should ensure that SiWG continues to function as engineered when the feature flag is removed. In the past, we've had issues where removal of the feature flag broke functionality. 😄